Add metadata to AOD#7501
Closed
nburmaso wants to merge 3 commits into
Closed
Conversation
jgrosseo
reviewed
Nov 3, 2021
| // note: `--aod-writer-resmode "UPDATE"` have to be used, | ||
| // so that metadata is not overwritten | ||
| mResFile += ".root"; | ||
| auto* fResFile = TFile::Open(mResFile, "UPDATE"); |
Collaborator
There was a problem hiding this comment.
Shouldn't this be written by using some O2 framework functions instead of doing it manually?
Contributor
Author
There was a problem hiding this comment.
It would be nice, but I'm not aware of a method that would allow writing an object outside of DF folder. Also, the code in this PR got mixed with some older code, so I will make another PR, where we can continue discussion :)
jgrosseo
reviewed
Nov 3, 2021
| Options{ | ||
| ConfigParamSpec{"aod-timeframe-id", VariantType::Int64, -1L, {"Set timeframe number"}}, | ||
| ConfigParamSpec{"enable-truncation", VariantType::Int, 1, {"Truncation parameter: 1 -- on, != 1 -- off"}}, | ||
| ConfigParamSpec{"prod-tags", VariantType::String, "LHC21Axx,pass1,LHC15o,pass1", {"Comma separated list of production tags: `LPMProductionTag,AnchorPassName,AnchorProduction,RecoPassName`"}}, |
Collaborator
There was a problem hiding this comment.
I propose one configSpec for each of the four strings
Contributor
Author
There was a problem hiding this comment.
I agree, this would be better. Done in #7503
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jgrosseo: This update partially covers O2-2656. TMap does not include
ProducerROOTVersion, as I did not find a way to fetch it from the framework in format likeheads/v5-34-00-patches.@sawenzel: Metadata is written to AOD before any tables, so that TMap could be written separately outside of DF. Tables should be written by aod-writer in
updatemode, so that metadata is not purged.This PR will be updated following changes in #7497 related to MC/RAW input data type.
I'm not sure if I write
TMapobject correctly, so please take a look